Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions for macOS #5938

Merged
merged 1 commit into from Apr 26, 2024
Merged

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Apr 25, 2024

The default macOS runners are now Ventura (14) which has added a realpath utility which causes brew's coreutils package to install realpath as grealpath. Follow brew's configuration advice for the PATH variable.

macOS Ventura (14) has added a realpath utility which causes brew's
coreutils package to install realpath as grealpath. Follow brew's
configuration advice for the PATH variable.
@kit-ty-kate
Copy link
Member

why do we need coreutils in CI on macOS?

@kit-ty-kate
Copy link
Member

answering to myself: the reftests

diff --git a/_build/default/tests/reftests/archive.test b/_build/default/tests/reftests/archive.out
index 69c2eaa..58ff033 100644
--- a/_build/default/tests/reftests/archive.test
+++ b/_build/default/tests/reftests/archive.out
@@ -938,7 +938,9 @@ The following actions will be performed:
 -> installed good-sha256-good-md5.1
 Done.
 ### sh check-cache.sh
-MD5: link, to sha256 archive
+realpath: illegal option -- m
+usage: realpath [-q] [path ...]

I feel like we could get rid of that usage instead so we're sure we're testing macOS correctly the way users actually use it

@dra27
Copy link
Member Author

dra27 commented Apr 26, 2024

Sure - in the meantime, we ought to get CI back up and running, though!

@dra27
Copy link
Member Author

dra27 commented Apr 26, 2024

Although there are two caveats to possibly not changing it: firstly, prior to Ventura IIUC, macOS did not have a realpath utility (it's just added it), but also the usage here is only (I think) in a checking function (i.e. the use of realpath is part of the test harness, not part of the opam being tested)

@kit-ty-kate
Copy link
Member

fair enough. I opened a TODO in #5940 to think about that later

@kit-ty-kate kit-ty-kate merged commit c8366f7 into ocaml:master Apr 26, 2024
29 checks passed
@kit-ty-kate kit-ty-kate added this to the 2.2.0~beta3 milestone Apr 26, 2024
@kit-ty-kate kit-ty-kate added this to Done in Opam 2.2.0 Apr 26, 2024
@dra27 dra27 deleted the keeping-macos-real branch April 26, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants