setup-ocaml/cache: allow creating cache key out of local repos #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorimoto
reviewed
Mar 16, 2023
psafont
force-pushed
the
local-urls
branch
2 times, most recently
from
f59f021
to
6bbfe72
Compare
|
Current commit created this cache key: Is this an acceptable name? |
psafont
changed the title
|
That looks good! |
|
@psafont Could you add a change log entry? |
smorimoto
added
enhancement
The location might be a relative filepath instead of a url, create a fallback path for these, sidestepping opam to create the url for all cases.
|
Should be good to go now! |
|
Fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not try to parse the location as url as it may be a relative filepath, this is a potential fix for #649
Not sure if it's the correct choice for all cases. Another option would be to read the URL from opam once it's been added, or generate it in an ad-hoc way from the relative filepath, then it could be passed to the function and in theory it should work, although you may want to add the u.hash as well to the urn