Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include blocks are not visibly demarcated. #54

Closed
jonludlam opened this issue Jul 29, 2021 · 2 comments
Closed

Include blocks are not visibly demarcated. #54

jonludlam opened this issue Jul 29, 2021 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jonludlam
Copy link
Member

Odoc usually shows a border on the right to show which sections come from included signatures. See the right-hand side of the include here:

Screenshot 2021-07-29 at 11 28 34

and the bottom of the included section here:
Screenshot 2021-07-29 at 11 29 29

@tmattio tmattio added the bug Something isn't working label Jul 29, 2021
@tmattio tmattio added this to the Package documentation milestone Jul 29, 2021
@tmattio tmattio added the good first issue Good for newcomers label Jul 29, 2021
tmattio pushed a commit that referenced this issue Sep 14, 2021
@JiaeK
Copy link
Contributor

JiaeK commented Oct 25, 2021

Hi, can I work on this issue? And can I get some details?

@jonludlam
Copy link
Member Author

Sure. The issue is that the CSS used for v3.ocaml.org comes partly from tailwind's typography plugin with some extra rules - and so is missing some of the rules declared in odoc's css. We need to port the rules relating to include blocks into v3's CSS file.

@tmattio tmattio closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

3 participants