Updating UI Fixes #212
Merged
Updating UI Fixes #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmattio
reviewed
Jan 13, 2022
manual/manual.css
Outdated
| @@ -8,8 +8,41 @@ | |||
| @import url(https://fonts.googleapis.com/css?family=Fira+Mono:400,500); | |||
There was a problem hiding this comment.
Let's revert this file, this is the manual generated from the compiler, we shouldn't change it
| @@ -147,6 +147,7 @@ about the strong academic roots of the language." @@ | |||
| <h2 class="mb-6 font-bold">Our influence</h2> | |||
| <div>See where we are located around the world at an academic level</div> | |||
| <div class="mt-24 relative"> | |||
| <<<<<<< Updated upstream | |||
There was a problem hiding this comment.
Some unsolved merge conflicts
| @@ -15,7 +15,7 @@ Package_layout.render | |||
| ~description:(Printf.sprintf "%s %s: %s" package.name package.version package.description) | |||
| ~tab:Documentation | |||
| ~package @@ | |||
| <button class="bg-primary-600 p-3 z-30 rounded-r-xl text-white shadow-md top-2/4 fixed md:hidden" | |||
| <button class="bg-primary-600 p-3 z-30 rounded-r-xl text-white shadow-md top-2/4 fixed lg:hidden left-0" | |||
There was a problem hiding this comment.
We should apply the same to problems and learn layout. Maybe worth extracting this to a component.
patricoferris
pushed a commit
to patricoferris/v3.ocaml.org-server
that referenced
this pull request
Sep 2, 2022
* update "Industrial Users" header to exactly match the Tailwind Playground implementation * also: fix hidden menu issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.