-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global navigation bar #86
Conversation
for building a global navigation bar. Data comes from a newly generated package.json file and some tests have been added for the parsing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work on this!
This LGTM overall - with some documentation for the added functions/modules, this is good to go I think!
@tmattio I've added a commit with the interface change. Personally I prefer the original version because the usage is more concise: the interface change requires to transform a lot of |
I was expecting the toplevel module to become |
Ah yes okay I finally get it. I think the |
LGTM, thanks @TheLortex, this is going to improve the navigation of packages documentation a lot! |
Co-authored-by: Thibaut <thibaut.mattio@gmail.com>
Supersedes #48
Now that voodoo generates a
package.json
file for each project containing the module map, we can implement a global navigation bar.The first commit parses the
package.json
, the second commit use the data structure to generate a navigation bar in the side panel along with the table of contents.This is a first iteration as a proof of concept, work on the design is needed. Moreover I had to remove the
fixed
class because the two sidebars were overlapping and were too long in any case (fixed
disable scrolling).Here is how it looks for the index page
Unfolded to the current module: