-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE!] Proposed packaging for opam releases #1
Conversation
Instructions in scripts/README.md document the process for creating a "release branch"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very elegant solution to package winpthreads, congratulations!
I pushed a couple of small suggestions with 2 commits on my 20240902-1 branch.
And I wondered about your first commit as I see it empty: was that on purpose?
@@ -0,0 +1,9 @@ | |||
#/bin/sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: this a comment instead of a shebang :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously, I meant it to be a Sixth Edition Unix Shell Script 😉
d635af4d9 again: | ||
|
||
```console | ||
$ git checkout -b 20240902-1 d635af4d9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn’t that meant to be 20240209 rather than 20240902?
Thanks, @shym - I've force pushed both typo suggestions to https://github.com/dra27/winpthreads/commits/opam. For the shell script, I guess I spend too long contorting around |
Branches pushed! |
I just found |
On my fork I have two branches 20240902-1 and opam which demonstrate a proposed means of producing tarballs automatically from GitHub commits.
This PR isn't intended to be merged; assuming we're happy with this I will push these two branches to this repo.
The idea is to create a package which when installed in opam provides the files needed for winpthreads when configuring OCaml (the packaging for Windows handles flexdll in the same way).
The tarball produced by this branch contains: