Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VScode 1.82.0 #1245

Merged
merged 4 commits into from
Oct 24, 2023
Merged

VScode 1.82.0 #1245

merged 4 commits into from
Oct 24, 2023

Conversation

smorimoto
Copy link
Collaborator

VScode v1.82.0 and later uses Electron v25, which uses Node.js v18 internally1, so we should be able to safely raise the ECMAScript version2.

Footnotes

  1. https://github.com/ewanharris/vscode-versions

  2. https://node.green

Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Collaborator Author

I have no strong incentive to do this for myself, but there should be no longer any users using <1.82.

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto merged commit c5fde25 into master Oct 24, 2023
7 checks passed
@smorimoto smorimoto deleted the vscode-1.82.0 branch October 24, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants