recompute env dict on every command #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EduardoRFS Could you add a change log entry for this? |
|
@smorimoto done boss, this patch really helps the life of Nix users |
smorimoto
approved these changes
Jan 5, 2024
smorimoto
reviewed
Jan 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Extensions may mutate the
process.envthis is especially true for https://github.com/direnv/direnv-vscode which will reset every property.But currently the
process.envis copied once during the load of the extension, making so that OCaml Platform and direnv are incompatible or need to be hacked around.