Fallback to ocaml.org documentation page #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sabine does it sound like a reasonable idea? |
smorimoto
reviewed
Jan 5, 2024
smorimoto
reviewed
Jan 5, 2024
tatchi
force-pushed
the
doc-fallback-to-ocamlorg
branch
from
5f4524a
to
9bfe28d
Compare
|
This PR also needs a change log entry! |
|
@tmattio do you have some feedback on this one? |
|
@tatchi Could you add a change log entry? |
|
These URLs are stable, so linking to them is fine. Sure, we can't guarantee the docs built on OCaml.org, but since it's a fallback that should be fine! @smorimoto |
|
Thanks 🙌 |
done (sorry for the delay) |
smorimoto
force-pushed
the
doc-fallback-to-ocamlorg
branch
from
e95b8bb
to
489f6a0
Compare
smorimoto
approved these changes
Mar 12, 2024
smorimoto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to the
ocaml.orgpackage documentation page if there is nodocfield in the package's opam file. Note that it doesn't currently check whether the page exists onocaml.org, so it may return a404error.Screen.Recording.2024-01-05.at.16.52.32.mov