refactor: move ocamllsp settings to extension #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ulugbekna and @Khady |
mnxn
reviewed
Jan 7, 2024
These aren't any general purpose bindings, they should live in the extension Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 54027297-8cd7-44d9-ac77-c358741660d8 -->
rgrinberg
force-pushed
the
ps/rr/refactor__move_ocamllsp_settings_to_extension
branch
from
c8d0ec3
to
58a066a
Compare
mnxn
approved these changes
Jan 7, 2024
rgrinberg
deleted the
ps/rr/refactor__move_ocamllsp_settings_to_extension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aren't any general purpose bindings, they should live in the
extension
Signed-off-by: Rudi Grinberg me@rgrinberg.com