Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve highlighting of labels and attributes/extensions #343

Merged
merged 4 commits into from
Aug 29, 2020

Conversation

mnxn
Copy link
Collaborator

@mnxn mnxn commented Aug 29, 2020

Highlighting of ~:

Old New
label-old label-new

Brackets inside of attributes/extension nodes interacted poorly; see the highlighting of the last "vscode":

Old New
bracket-old bracket-new

@mnxn
Copy link
Collaborator Author

mnxn commented Aug 29, 2020

Added a small change to highlight label names inside of parentheses:
label-paren-new

@rgrinberg
Copy link
Contributor

I think I messed up the change log earlier, and missed the entry for 1.0. So this PR needs to be rebased.

@mnxn mnxn merged commit 01e19a2 into ocamllabs:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants