fix #559

[tatchi]

The problem was that Params was an array of array of string, while the lsp server was expecting an array of string.

I fixed it on the extension side, but if we want to keep sending an array of array of string, we can instead adapt the lsp as following:

diff --git a/ocaml-lsp-server/src/custom_requests/req_switch_impl_intf.ml b/ocaml-lsp-server/src/custom_requests/req_switch_impl_intf.ml
index 15733db..84c24b9 100644
--- a/ocaml-lsp-server/src/custom_requests/req_switch_impl_intf.ml
+++ b/ocaml-lsp-server/src/custom_requests/req_switch_impl_intf.ml
@@ -14,7 +14,8 @@ let switch (param : DocumentUri.t) : (Json.t, Jsonrpc.Response.Error.t) result =
 let on_request ~(params : Jsonrpc.Message.Structured.t option) _ =
   Fiber.return
     ( match params with
-    | Some (`List [ `String (file_uri : DocumentUri.t) ]) -> switch file_uri
+    | Some (`List [ `List [ `String (file_uri : DocumentUri.t) ] ]) ->
+      switch file_uri
     | Some json ->
       Error
         (Jsonrpc.Response.Error.make ~code:InvalidRequest

[mnxn]

Thanks!

I can confirm this fixes it for ocaml-lsp 1.4.0. Handling a nested list in the language server doesn't look right, so I think fixing it on the extension side is the correct decision.

I believe this happened because after vscode-languageclient 7.0.0, LanguageClient.sendRequest automatically wrapped the parameter in a list, so adding the Jsonoo.Encode.list was unnecessary.

[tmattio]

I believe this happened because after vscode-languageclient 7.0.0

Correct, I had to fix the unit tests on the LSP side because of that too: https://github.com/ocaml/ocaml-lsp/pull/385/files

[tmattio]

@tatchi Could you add an entry in the Changelog for this?

[tmattio]

Thanks 🎉