New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace call to boot() from Jaccard() #26
Comments
Should be simple enough, given that FWIW, the boot package's license is "unlimited" (source), so reusing the code itself might be straightforward. |
Since commit 13455a9 eliminated the need for the readr package, the devtools check no longer issues a "lots of dependencies" note. In this case, it might be better to leave the boot dependency, as the additional code might offset the time saved by having one fewer dependency. In any case, perhaps a simple copy-pasting of the original code could be used as a test to see if it checks faster than having the extra dependency. In the end, check time is arguably the biggest issue to be tackled here. |
DIscBIO contains the boot package as a dependency just for the purpose of using the
boot()
function insideJaccard()
(see here). If this were to be replaced by an in-house solution, there would be one fewer dependency for DIscBIO (which is currently depending on 21 non-default packages; this generates a NOTE fromdevtools::check()
).The text was updated successfully, but these errors were encountered: