Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create demo tables #25

Closed
5 tasks done
wleoncio opened this issue Oct 28, 2021 · 0 comments
Closed
5 tasks done

Create demo tables #25

wleoncio opened this issue Oct 28, 2021 · 0 comments
Milestone
MVP for the next ...

Comments

@wleoncio
Copy link
Member

wleoncio commented Oct 28, 2021 •
edited

Most of the function examples are from the same few tables, properly documented with references as comments in the examples themselves. These would looks better as package-level tables that users can call directly.

  • Create demo tables
  • Create aliases for table_*.* objects (to also use the reference name)
  • Create unit tests for these tables
  • Use these tables in the function examples
  •  Use these tables in the unit tests for the functions

Adding a bit more explanation, the proposal is to create data objects for the literature examples: for example, Singh et al. (2010) provides the (X=250, n=533) pair of values that is used by several functions. I imagine it would be useful for the package to come with an object like singh_et_al_2010 that would contain those values that could then be used across the package and by the users themselves. This comes with the added benefit of smaller code footprint and a dedicated documentation page for singl_et_al_2010.
@wleoncio wleoncio added this to the MVP for 1.1.0 milestone Apr 21, 2022
wleoncio added a commit that referenced this issue Jun 7, 2022
@wleoncio
Replaced some tables with datasets (#25)
3f128b1 
- lampasona_2013
- ritland_2007
- perondi_2004
- singh_2010
- ligarden_2010
- tea
- peterson_2007
- bentur_2009
- cavo_2012
- ear_infection
- fontanella_2008
- lydersen_2012a
- doll_hill_1950
- hine_1989
- hypothetical
- mills_graubard_1987
- indredavik_2008
- table_7.5
- table_7.6
wleoncio added a commit that referenced this issue Jun 7, 2022
@wleoncio
Aligned Tables 7.5 and 7.6 with book (#25)
4580beb
wleoncio added a commit that referenced this issue Jun 7, 2022
@wleoncio
Renamed table (#25)
1fb88b0
wleoncio added a commit that referenced this issue Jun 7, 2022
@wleoncio
Fixed syntax (#25)
c4c16b3
wleoncio added a commit that referenced this issue Jun 7, 2022
@wleoncio
Added data table 7.7, 7.8 and 7.9 (#25)
6659581 
Also, updated docs for 7.3 and 7.5.
wleoncio added a commit that referenced this issue Jun 7, 2022
@wleoncio
More tables, more replacements (#25)
ca92a9d 
- ezra_2010
- fleiss_2003
- snp6498169
wleoncio added a commit that referenced this issue Jul 20, 2022
@wleoncio
Added data table 7.4 (#25)
459a932
wleoncio added a commit that referenced this issue Jul 20, 2022
@wleoncio
Added fisher_1999 table (#25)
d064442
wleoncio added a commit that referenced this issue Jul 20, 2022
@wleoncio
Added aliases to table_7.* (#25)
a33a3ed
wleoncio added a commit that referenced this issue Jul 20, 2022
@wleoncio
Using package tables in tests (#25)
3300e81
wleoncio added a commit that referenced this issue Jul 21, 2022
@wleoncio
Fixed documentation (#25)
5e7e7ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MVP for the next feature release
Development

No branches or pull requests
1 participant
@wleoncio