Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chacko_test_1xc #36

Closed
2 tasks done
wleoncio opened this issue Nov 8, 2022 · 0 comments
Closed
2 tasks done

Chacko_test_1xc #36

wleoncio opened this issue Nov 8, 2022 · 0 comments
Assignees
@wleoncio
Labels
bug Something isn't working

Comments

@wleoncio
Copy link
Member

wleoncio commented Nov 8, 2022 •
edited

The following code causes an error:

Chacko_test_1xc(c(6,8,4,7,3))

Error in if (nt[i] > nt[i + 1]) { : argument is of length zero

The problem beind that at one point i = 0, so nt[i] is a zero-length vector. The loop probably needs some refactoring

  • Add more tests to the function to make sure the original calculations are preserved
  • Refactor loop so that Chacko_test_1xc(c(6,8,4,7,3)) works.

Credit to Prof. Graeme Ruxton (Univ. of St. Andrews) for finding the bug.
@wleoncio wleoncio added the bug Something isn't working label Nov 8, 2022
@wleoncio wleoncio self-assigned this Nov 8, 2022
wleoncio added a commit that referenced this issue Nov 10, 2022
@wleoncio
Adding requirement that m > 2 (#36)
4a9cd4d 
The test statistic is asymptotically chi-square with m - 1 d.f., so the added restriction makes sense so that d.f. is positive
wleoncio added a commit that referenced this issue Nov 10, 2022
@wleoncio
Changed ordering process algorithm (#36)
f725c32
wleoncio added a commit that referenced this issue Nov 10, 2022
@wleoncio
Refactored calculation of test statistic, p-value (#36)
b02e863
wleoncio added a commit that referenced this issue Nov 10, 2022
@wleoncio
Added unit tests (#36)
8b541d9
@wleoncio wleoncio mentioned this issue Nov 23, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wleoncio wleoncio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wleoncio