Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve argument validation of "direction" argument #45

Closed
wleoncio opened this issue May 5, 2023 · 0 comments
Closed

Improve argument validation of "direction" argument #45

wleoncio opened this issue May 5, 2023 · 0 comments
Assignees
@wleoncio
Labels
minor feature Implementing this should not break backwards compatibility

Comments

@wleoncio
Copy link
Member

wleoncio commented May 5, 2023

Functions using direction as an argument tend to throw a cryptic error message when that arg is missing. See example below:

R> Exact_cond_midP_unspecific_ordering_rx2(t(lydersen_2012a))
Error in match(x, table, nomatch = 0L) : «match» tek berre vektorargument
@wleoncio wleoncio added enhancement minor feature Implementing this should not break backwards compatibility and removed enhancement labels May 5, 2023
@wleoncio wleoncio self-assigned this Sep 18, 2023
wleoncio added a commit that referenced this issue Sep 18, 2023
@wleoncio
Updated NEWS.md (#45)
9a21603
wleoncio added a commit that referenced this issue Sep 18, 2023
@wleoncio
Added unit tests for #45
06971ae
wleoncio added a commit that referenced this issue Sep 18, 2023
@wleoncio
Merge branch 'issue-45' into develop
eb4eef8 
* issue-45:
  Added unit tests for #45
  Updated NEWS.md (#45)
  Added comments
  Improved parsing of `direction` (fixes #45)
  Increment version number to 2.1.1.9003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wleoncio wleoncio

Labels
minor feature Implementing this should not break backwards compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wleoncio