Blending using the GPU #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umireon
previously requested changes
Apr 12, 2023
cmake/ObsPluginHelpers.cmake
Outdated
Comment on lines
466
to
471
|
|
||
| # ignore .DS_Store files | ||
| if(_DATA_FILE MATCHES ".DS_Store") | ||
| continue() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
We don't need this - All the releases from CI and CI won't generate .DS_Store.
It would be great to keep this file identical to template's one.
|
The contour is not smooth.
|
|
The edge is flickering when the blur is turned on. |
umireon
reviewed
Apr 13, 2023
Co-authored-by: Kaito Udagawa <umireon@gmail.com>
Co-authored-by: Kaito Udagawa <umireon@gmail.com>
umireon
reviewed
Apr 13, 2023
Co-authored-by: Kaito Udagawa <umireon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of our OpenCV (CPU) based image blending - use the GPU and the HLSL shaders to do the application of the mask to the image. It's faster and relieves the CPU from rendering duties,