Fix PKGBUILD

[umireon]

Closes #262
Closes #172
Closes #34

[ngoonee]

On Arch this still results in

make[2]: *** No rule to make target 'OpenCV_Build-prefix/lib/libopencv_imgproc.a', needed by 'obs-backgroundremoval.so'. Stop.

[umireon]

@ngoonee
I have tested this PKGBUILD on my Arch Linux and the build has ended successfully.
Could you ensure you are using the latest PKGBUILD on this PR and test the build again?
Please attach the full log here if the problem still persists.

[ngoonee]

The PKGBUILD I am using is this one (from the PR) -
PKGBUILD.txt

The full build log is here -
errors.txt

[umireon]

@ngoonee Can you create a completely clean build tree and try to run makepkg -s?

git clone https://github.com/royshil/obs-backgroundremoval.git
git switch umireon.fix-arch-pkgbuild
cd scripts
makepkg -s

And can you tell me what commands you used to create your build?

It seems that OpenCV built shared libraries and this resulted in the file missing error because this plugin expected statically-linking OpenCV libraries.

[JayceFayne]

@ngoonee Can you create a completely clean build tree and try to run makepkg -s?

git clone https://github.com/royshil/obs-backgroundremoval.git
git switch umireon.fix-arch-pkgbuild
cd scripts
makepkg -s

And can you tell me what commands you used to create your build?

It seems that OpenCV built shared libraries and this resulted in the file missing error because this plugin expected statically-linking OpenCV libraries.

I created a clean checkout and can confirm that the error still persists

[ 72%] Completed 'OpenCV_Build'
[ 72%] Built target OpenCV_Build
make[2]: *** No rule to make target 'OpenCV_Build-prefix/lib/libopencv_imgproc.a', needed by 'obs-backgroundremoval.so'.  Stop.
make[2]: *** Waiting for unfinished jobs....
[ 81%] Building CXX object CMakeFiles/obs-backgroundremoval.dir/src/plugin-main.cpp.o
[ 90%] Building CXX object CMakeFiles/obs-backgroundremoval.dir/src/background-filter.cpp.o
make[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/obs-backgroundremoval.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...
    ```

[umireon]

I have updated the PKGBUILD to use the system OpenCV library and now everything will go fine.
@ngoonee @JayceFayne Can you try this again?

[umireon]

I believe #257 must be merged to get this plugin worked on Arch but just building will work by this PR.

[JayceFayne]

Can confirm, build passes now! 🎉

[umireon]

For now, you can check if the CPU version works by removing libonnxruntime_providers_*.so.

sudo rm /usr/lib/obs-plugins/libonnxruntime_providers_*.so

[JayceFayne]

I have updated the PKGBUILD to use the system OpenCV library and now everything will go fine. @ngoonee @JayceFayne Can you try this again?

Works fine with the version built from this PKGBUILD
Maybe because I am using the CPU version? (I have an AMD GPU)

[umireon]

The GPU version is still broken now.

[royshil]

The GPU version is still broken now.

Should we merge this and take of GPU in another PR? @umireon

[umireon]

The GPU feature on Linux will be fixed on #257

[umireon]

I suppose the remaining problem reported on #257 is an issue of setting up CUDA and not an issue of this plugin.

[royshil]

lgtm