fix: Windows CUDA compilation was incorrectly described #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No problem, is it mergeable or anything else should be done? |
noup. fire away |
|
@Destroy666x please merge latest master to your branch, it has a fix for the windows build |
…mpilationHelpers * upstream/master: openblas sha lint models to config folder
|
@royshil done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
-ExtraCmakeFlagsparam was incorrect-ExtraCmakeFlagsdidn't work as full string, turned it into string array to match code belowWorked fine on CUDA 12.2 after these changes and the plugin is now more or less usable on lives with my CPU 🚀
Another thing to optimize may be to copy the mentioned DLLs from
%CUDA_TOOLKIT_ROOT_DIR%\binto therelease\obs-plugins\64bitfolder, but I'm unfortunately not familiar enough with CMake (first time using it for OBS stuff) to know how to do this optimally. Unless it can just happen at the end of PowerShell script?