Add Power ppc64le platform support #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case of data equal to "".
Recompile gtest by obdevtools-gcc9 with -O2 -fPIC options
Add powerpc64 support
Add compile options for powerpc64
DBres4Power
commented
Jun 25, 2024
DBres4Power
commented
Jun 25, 2024
src/lib/oblog/ob_log.cpp
Outdated
There was a problem hiding this comment.
测试发现有data 为""时，虽不是NULL or nullptr ，但strlen是0，会导致logdata_vprintf函数中 vsnprintf调用出问题
deps/3rd/dep_create.sh
Outdated
| case "$ID" in | ||
| centos) | ||
| version_ge "8.0" && compat_centos8 && return | ||
| version_ge "7.0" && compat_centos7 && return |
There was a problem hiding this comment.
ppc64现阶段就没打7的依赖，就先删掉吧，这里还是不支持比较好
rpm/obproxy-ce-VER.txt
Outdated
| @@ -1 +1 @@ | |||
| 4.2.1.0 | |||
| 4.2.3.0 | |||
There was a problem hiding this comment.
这里版本号为何更新了，是为了匹配observer的版本号吗
如果是的话，这不用动，让内部修改
| @@ -46,8 +46,8 @@ | |||
|
|
|||
| extern "C" { | |||
| struct _ParseNode; | |||
| extern uint64_t parsenode_hash(const _ParseNode *node); | |||
| extern bool parsenode_equal(const _ParseNode *node1, const _ParseNode *node2); | |||
| extern uint64_t parsenode_hash(const _ParseNode *node, int *ret); | |||
There was a problem hiding this comment.
这里我没有细看依赖的实现和obproxy的调用，插个眼，请proxy的同学帮忙看看
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Power ppc64le platform support.
Solution Description
Patch to following files:
configure.ac
deps/3rd/dep_create.sh
deps/3rd/obproxy.el8.ppc64le.deps
deps/easy/src/include/easy_atomic.h
deps/easy/src/io/ev.c
deps/easy/src/util/easy_time.c
rpm/obproxy-ce-VER.txt
src/lib/atomic/ob_atomic.h
src/lib/cbtree/btree.h
src/lib/checksum/ob_crc64.cpp
src/lib/hash/ob_hashutils.h
src/lib/list/ob_atomic_list.h
src/lib/lock/ob_latch.cpp
src/lib/oblog/ob_log.cpp
src/lib/stat/ob_di_cache.cpp
src/obproxy/obutils/ob_config_server_processor.cpp
src/obproxy/opsql/parser/ob_proxy_parse_result.h
src/obproxy/utils/ob_proxy_table_define.h
unittest/obproxy/Makefile.am
unittest/obproxy/test_atomic_store.cpp