Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): Table locale & BatchOperationBar keys should related rowSelection #591

Merged
merged 5 commits into from
May 23, 2024

Conversation

linhf123
Copy link
Collaborator

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  1. BatchOperationBar less locale
  2. BatchOperationBar don't related rowSelection
  3. API Unrealized
Before After
image image

📝 Changelog

Language Changelog
🇺🇸 English Fix batchOperationBar don't related rowSelection and locale
🇨🇳 Chinese 修复批量操作栏未关联 rowSelection ,以及缺少国际化

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented May 21, 2024

@dengfuping dengfuping changed the title fix(Table): locale & BatchOperationBar keys should related rowSelection fix(design): Table locale & BatchOperationBar keys should related rowSelection May 23, 2024
@dengfuping dengfuping merged commit 12a834c into master May 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants