Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code comment typo #32

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix code comment typo #32

merged 1 commit into from
Jun 15, 2021

Conversation

ehds
Copy link
Contributor

@ehds ehds commented Jun 1, 2021 •
edited

Fix some code comment typo.

Amber1990Zhang
Amber1990Zhang approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@Amber1990Zhang Amber1990Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Nice catch. LGTM

@LINxiansheng
Copy link
Contributor

Thanks for your comments, I know your comments is correct.
Source code even annotation fix will be later.

@MizuhaHimuraki MizuhaHimuraki added this to the v3.1.0_CE_rc2 milestone Jun 11, 2021
LINxiansheng
LINxiansheng approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@LINxiansheng LINxiansheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@MizuhaHimuraki MizuhaHimuraki merged commit fcf52f5 into oceanbase:master Jun 15, 2021
This was referenced Jul 14, 2022
Closed
Closed
Closed
@imbawenzi imbawenzi mentioned this pull request Jul 22, 2022
Closed
1 task
This was referenced Nov 17, 2022
Closed
Open
Closed
Open
Closed
@imbawenzi imbawenzi mentioned this pull request Dec 18, 2022
Open
2 tasks
@imbawenzi imbawenzi mentioned this pull request Feb 2, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LINxiansheng LINxiansheng LINxiansheng approved these changes

@Amber1990Zhang Amber1990Zhang Amber1990Zhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0_CE_bp1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehds @LINxiansheng @Amber1990Zhang @MizuhaHimuraki