Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create explicit test script which ensures the installed package works as intended? #1395

Closed
willirath opened this issue Jul 10, 2023 · 4 comments

Comments

@willirath
Copy link
Collaborator

In conda-forge/parcels-feedstock#98, we're discussing how to ensure that the installed Parcels package and all dependencies work as intended (especially in the JITParticle case which is the one requiring careful setup of the environment).

Currently, the package is tested by running the peninsula example. This test can, however, complete successfully even if the compilers installed as a dependency of the parcels conda package are not working, if parcels falls back to compilers provided by the operating system.

Maybe we can add a script (not sure where) which sets up the compiler and logs path, version, etc. of the compiler which it found and fails if there's no compiler found? Having this as part of the Parcels repository rather than in the Conda-Forge feedstock feels more natural as here also would be the place where any future changes of the way JIT compilation is done would happen.

@erikvansebille
Copy link
Member

I think this is a very good idea, @willirath. We could make a tests/test_compliation.py script and run that with pytest on conda-forge? Could you make a proposal what it exactly needs to test then?

@ngam
Copy link

ngam commented Jul 10, 2023

@erikvansebille and @willirath, we could also try to run more of your test suite (unless it takes forever) on the conda-forge side. Would you like me to enable that in conda-forge/parcels-feedstock#98?

@willirath
Copy link
Collaborator Author

@erikvansebille and @willirath, we could also try to run more of your test suite (unless it takes forever) on the conda-forge side. Would you like me to enable that in conda-forge/parcels-feedstock#98?

Not sure this is necessary. The run of the one example script in https://github.com/ngam/parcels-feedstock/blob/aarches/recipe/meta.yaml#L60 already includes the one critical dependency as it triggers the just-in-time compilation part of the logic of Parcels.

@erikvansebille
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants