Remove jsonsempai. #997
Merged
Remove jsonsempai. #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calina-c
force-pushed
the
remove-jsonsempai
branch
from
9a78c67
to
d96c537
Compare
aquarius/events/events_monitor.py
Outdated
| @@ -571,7 +565,7 @@ def get_and_process_event_logs_for_one_block(self, block): | |||
| try: | |||
| logs = self._web3.eth.get_logs(filter_params) | |||
| self.process_logs(logs, block) | |||
| except Exception as e: | |||
| except Exception: | |||
There was a problem hiding this comment.
should we keep the error and print it if possible?
There was a problem hiding this comment.
there's already an explicit error logged. I can print out the text if you think it's needed. I just removed the unused variable based on pre-commit issues, but let me know
There was a problem hiding this comment.
yes please, print the e message.
calina-c
force-pushed
the
remove-jsonsempai
branch
from
263164f
to
94efc94
Compare
|
Code Climate has analyzed commit 5c320aa and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 84.5%. View more on Code Climate. |
mariacarmina
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.