Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ocean contracts #220

Merged
merged 10 commits into from Sep 17, 2020
Merged

Feature/ocean contracts #220

merged 10 commits into from Sep 17, 2020

Conversation

ssallam
Copy link
Contributor

@ssallam ssallam commented Sep 11, 2020

  • run ocean-contracts docker to deploy contracts
  • update aquarius inputs as required by the decentralized ddo version

@ssallam ssallam requested a review from a team September 11, 2020 06:37
@ssallam ssallam requested a review from a team as a code owner September 11, 2020 06:37
export DEPLOY_CONTRACTS="true"
export OCEAN_ARTIFACTS_FOLDER="${OCEAN_HOME}/ocean-contracts/artifacts"
# Specify which ethereum client to run or connect to: development
export CONTRACTS_NETWORK_NAME="ganache"
Copy link
Member

@alexcos20 alexcos20 Sep 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export CONTRACTS_NETWORK_NAME="ganache"
export CONTRACTS_NETWORK_NAME="ganache"
export CONTRACTS_VERSION="test"

@kremalicious
Copy link
Contributor

ocean-contracts needs to be added to main README, in the table and as a building block

start_ocean.sh Outdated
@@ -27,12 +27,16 @@ DIR="${DIR/ /\\ }"
COMPOSE_DIR="${DIR}/compose-files"

# Default versions of Aquarius, Provider
export AQUARIUS_VERSION=${AQUARIUS_VERSION:-v3}
export AQUARIUS_VERSION=${AQUARIUS_VERSION:-latest}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export AQUARIUS_VERSION=${AQUARIUS_VERSION:-latest}
export AQUARIUS_VERSION=${AQUARIUS_VERSION:-decentralized}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcos20 alexcos20 merged commit 5f894dc into v3 Sep 17, 2020
@alexcos20 alexcos20 deleted the feature/ocean-contracts branch September 17, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants