Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions visibility #191

Closed
0x3bfc opened this issue Aug 31, 2020 · 0 comments
Closed

Functions visibility #191

0x3bfc opened this issue Aug 31, 2020 · 0 comments

Comments

@0x3bfc
Copy link

0x3bfc commented Aug 31, 2020

initialize(string,string,address,uint256,string,address) should be declared external:
        - DataTokenTemplate.initialize(string,string,address,uint256,string,address) (templates/DataTokenTemplate.sol#106-126)
mint(address,uint256) should be declared external:
        - DataTokenTemplate.mint(address,uint256) (templates/DataTokenTemplate.sol#187-200)
startOrder(address,uint256,bytes32,uint256,address,uint256) should be declared external:
        - DataTokenTemplate.startOrder(address,uint256,bytes32,uint256,address,uint256) (templates/DataTokenTemplate.sol#212-256)
finishOrder(bytes32,address,uint256,bytes32,uint256) should be declared external:
        - DataTokenTemplate.finishOrder(bytes32,address,uint256,bytes32,uint256) (templates/DataTokenTemplate.sol#269-292)
pause() should be declared external:
        - DataTokenTemplate.pause() (templates/DataTokenTemplate.sol#300-302)
unpause() should be declared external:
        - DataTokenTemplate.unpause() (templates/DataTokenTemplate.sol#310-312)
setMinter(address) should be declared external:
        - DataTokenTemplate.setMinter(address) (templates/DataTokenTemplate.sol#321-323)
name() should be declared external:
        - DataTokenTemplate.name() (templates/DataTokenTemplate.sol#330-332)
symbol() should be declared external:
        - DataTokenTemplate.symbol() (templates/DataTokenTemplate.sol#339-341)
blob() should be declared external:
        - DataTokenTemplate.blob() (templates/DataTokenTemplate.sol#348-350)
decimals() should be declared external:
        - DataTokenTemplate.decimals() (templates/DataTokenTemplate.sol#358-360)
cap() should be declared external:
        - DataTokenTemplate.cap() (templates/DataTokenTemplate.sol#367-369)
isMinter(address) should be declared external:
        - DataTokenTemplate.isMinter(address) (templates/DataTokenTemplate.sol#377-379)
isInitialized() should be declared external:
        - DataTokenTemplate.isInitialized() (templates/DataTokenTemplate.sol#386-388)
isPaused() should be declared external:
        - DataTokenTemplate.isPaused() (templates/DataTokenTemplate.sol#395-397)
calculateTotalFee(uint256,uint256) should be declared external:
        - DataTokenTemplate.calculateTotalFee(uint256,uint256) (templates/DataTokenTemplate.sol#425-436)
isInitialized() should be declared external:
        - BPool.isInitialized() (balancer/BPool.sol#104-106)
initialize(address,address,uint256,bool,bool) should be declared external:
        - BPool.initialize(address,address,uint256,bool,bool) (balancer/BPool.sol#115-127)
setPublicSwap(bool) should be declared external:
        - BPool.setPublicSwap(bool) (balancer/BPool.sol#302-310)
createToken(string,string,string,uint256) should be declared external:
        - DTFactory.createToken(string,string,string,uint256) (DTFactory.sol#68-111)
newBPool() should be declared external:
        - BFactory.newBPool() (balancer/BFactory.sol#47-66)
setCompleted(uint256) should be declared external:
        - Migrations.setCompleted(uint256) (Migrations.sol#16-18)
owner() should be declared external:
        - Ownable.owner() (openzeppelin-solidity/contracts/ownership/Ownable.sol#30-32)
renounceOwnership() should be declared external:
        - Ownable.renounceOwnership() (openzeppelin-solidity/contracts/ownership/Ownable.sol#56-59)
balanceOf(address) should be declared external:
        - ERC20.balanceOf(address) (openzeppelin-solidity/contracts/token/ERC20/ERC20.sol#50-52)
allowance(address,address) should be declared external:
        - ERC20.allowance(address,address) (openzeppelin-solidity/contracts/token/ERC20/ERC20.sol#70-72)

Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#public-function-that-could-be-declared-as-external

0x3bfc added a commit that referenced this issue Aug 31, 2020
@0x3bfc 0x3bfc closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant