-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "dataToken" -> "datatoken" etc, everywhere #450
Comments
This was referenced Jan 13, 2022
This was referenced Jan 13, 2022
lacoop6tu
added a commit
that referenced
this issue
Jan 16, 2022
Please add your planning poker estimate with ZenHub @lacoop6tu |
Merged
Make sure that baseToken remains unchanged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
It's not "data token". There is no space, it's "datatoken"; It's a single word; there are several reasons for this.
v3 wasn't filly consistent this way. Let's take the opportunity to make v4 consistent, before we ship the first version.
Searching for "datatoken" in the repo reveals "dataToken" in a few places. Searching "data token" reveals more. These need fixing.
https://github.com/oceanprotocol/contracts/search?q=datatoken
Describe the solution you'd like
Everywhere in ocean.py, replace:
Additional context
A "datatoken" is the ERC20 fungible token. Complementary to it is the "Data NFT", an ERC721 non-fungible token. "Data NFT" does have a space.
Related issues: ocean.py, ocean.js
The text was updated successfully, but these errors were encountered: