Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/opf fee flexibility #349

Merged
merged 9 commits into from
Sep 29, 2021
Merged

Feature/opf fee flexibility #349

merged 9 commits into from
Sep 29, 2021

Conversation

lacoop6tu
Copy link
Contributor

Fixes # .

Changes proposed in this PR:

  • OPF fee can be updated and read from the Router.
  • OPF fee will change dynamically (new value or new token into Ocean List)
  • Pools and FixedRateExchange now use dynamic fee from the Router. Add tests

@lacoop6tu lacoop6tu marked this pull request as ready for review September 28, 2021 18:27
@lacoop6tu lacoop6tu merged commit ba3fd74 into v4main Sep 29, 2021
@MantisClone MantisClone deleted the feature/opfFee-flexibility branch December 28, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 alexcos20 approved these changes

@trentmc trentmc Awaiting requested review from trentmc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lacoop6tu @alexcos20