-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files for building and publishing NPM and PyPi package #350
Conversation
@alexcos20 requested change: Only execute the |
This reverts commit 75c7f85. Removing this dependency allows the lint and full_test to run parallel
…st in main" This reverts commit 71319df. This commit proved that the workflow file could be successfully parsed. However, the ref should be the main branch when this gets merged to main
* Download "coverage" artifact failed to overwrite coverage directory
This reverts commit 894c833. Attempt didn't fix the CI.coverage workflow
I believe this PR is complete and ready to be reviewed. |
@alexcos20 requested change: Add bump version script to keep NPM version and PyPi version in sync. |
* setup.cfg describes the contents of the sdist and wheel no need to duplicate the info in MANIFEST.in MANIFEST.in only adds files to the the sdist, not the wheel
* include addresses/ and artifacts/ directories
@alexcos20 I also fixed a bug where the sdist package contained the And finally, I merged #367 into this branch because the presence of the |
…ranch)" This reverts commit b535088. Workflow printed the following error: handling usage of workflow "oceanprotocol/contracts/.github/workflows/ci.yml@HEAD": can't obtain workflow file: reference to workflow should be either a valid branch, tag, or commit
Towards #348
Changes proposed in this PR:
artifacts/
directory to contain valid python modules..
with_
__init__.py
files to every directorypyproject.toml
is needed for thepython -m build
command to worksetup.cfg
defines the PyPi metadata and directories to include in the sdist/wheelv1.0.0-alpha.1
. See for details: Release an alpha version of the Ocean Contracts to PyPi #348 (comment).bumpversion.cfg
andbumpversion.sh
script to keep the npm and python package versions in syncReusable Workflows
This PR makes the
ci
workflow "reusable" meaning it can be called from other workflows (even ones in other repositories). Both thenpm-publish
andpython-publish
workflows call theci
workflow.The reference to a workflow must be a valid branch, tag, or commit, so I've selected
v4main
as the ref. But, theci
workflow onv4main
is currently not reusable, and so the npm/python-publish workflows fail with the following error:This error will be resolved once this PR is merged to
v4main
.Python Package Contents
The sdist and wheel packages contain identical contents, shown below.