Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/small refactors #387

Merged
merged 12 commits into from
Nov 16, 2021
Merged

Feature/small refactors #387

merged 12 commits into from
Nov 16, 2021

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Nov 11, 2021

Changes proposed in this PR:

  • ERC721: add new function setMetaDataState (allows publisher to change state using a cheap function)
  • ERC721: added MetadataState event so Aquarius can track for state changes
  • Remove all indexed strings in events (a string should never be indexed in a event)
  • Adding more details to some events (ERC721, Dispenser, ERC20)
  • Proper use of tokenURI in ERC721

@mihaisc - do you need anything else for the graph?

@alexcos20 alexcos20 self-assigned this Nov 11, 2021
@alexcos20 alexcos20 marked this pull request as ready for review November 11, 2021 15:49
@mihaisc
Copy link
Contributor

mihaisc commented Nov 12, 2021

I'd say we are good, didn't find anything else.

@alexcos20 alexcos20 marked this pull request as draft November 12, 2021 13:12
@alexcos20
Copy link
Member Author

alexcos20 commented Nov 12, 2021

Still needs some changes on the pool side, we have some view functions with events and we are missing events for fees. WIP
All good

@alexcos20 alexcos20 marked this pull request as ready for review November 12, 2021 16:06
@mihaisc
Copy link
Contributor

mihaisc commented Nov 15, 2021

can we rename feeManager (from erc20) , from my understanding this is not related to fees, this is the account where the payments are collected so ...something like paymentCollector (or a better suggestion )

@alexcos20 alexcos20 merged commit 3671ed1 into v4main Nov 16, 2021
@alexcos20 alexcos20 deleted the feature/small_refactors branch November 16, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants