Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restructure order events #413

Merged
merged 4 commits into from
Nov 25, 2021
Merged

restructure order events #413

merged 4 commits into from
Nov 25, 2021

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Nov 24, 2021 •
edited

Changes proposed in this PR:

  • new events for fees on consume & publish (much easy to track them in subgraph)
  • make sure events are emitted only on transfers
  • fix some bugs regarding transfer conditions

@alexcos20 alexcos20 self-assigned this Nov 24, 2021
@alexcos20 alexcos20 marked this pull request as ready for review November 24, 2021 17:52
@alexcos20 alexcos20 changed the title restructure events restructure order events Nov 24, 2021
@alexcos20 alexcos20 added this to the V4 milestone Nov 24, 2021
@alexcos20 alexcos20 merged commit 1428b11 into v4main_postaudit Nov 25, 2021
@alexcos20 alexcos20 deleted the feature/restructure_order_events branch November 25, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lacoop6tu lacoop6tu Awaiting requested review from lacoop6tu

@trentmc trentmc Awaiting requested review from trentmc

@mihaisc mihaisc Awaiting requested review from mihaisc

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
V4
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alexcos20