Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/signed provider fees #430

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Feature/signed provider fees #430

merged 2 commits into from
Dec 20, 2021

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Dec 14, 2021 •
edited

Changes proposed in this PR:

  • remove amount from startOrder, it's always 1DT (hardcoded: 1e18)
  • add ERC20Roles: getPermisions
  • add providerSignature (r,v,s) and providerData - so a Provider can make sure that the fees are correct
    Details:
  • Provider signs keccak(providerData, providerAddress, token, amount) and this gets verified in startOrder

@alexcos20 alexcos20 self-assigned this Dec 14, 2021
@alexcos20 alexcos20 merged commit 352db75 into v4main_postaudit Dec 20, 2021
@alexcos20 alexcos20 deleted the feature/signed_provider_fees branch December 20, 2021 13:18
@alexcos20 alexcos20 restored the feature/signed_provider_fees branch December 20, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lacoop6tu lacoop6tu lacoop6tu approved these changes

@trentmc trentmc Awaiting requested review from trentmc

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexcos20 @lacoop6tu