Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add licence headers #460

Merged
merged 1 commit into from
Jan 18, 2022
Merged

add licence headers #460

merged 1 commit into from
Jan 18, 2022

Conversation

alexcos20
Copy link
Member

Closes #457

Changes proposed in this PR:

  • add licence headers

@trentmc @kremalicious @lacoop6tu - need you double check pls

PS: Artifacts & deployment are not included, will do that after several PRs

@alexcos20 alexcos20 added this to the V4 milestone Jan 16, 2022
@alexcos20 alexcos20 self-assigned this Jan 16, 2022
@alexcos20 alexcos20 linked an issue Jan 16, 2022 that may be closed by this pull request
@kremalicious
Copy link

seems alright, only the parentheses for the SPDX-License-Identifier might not be needed when looking at https://spdx.dev/ids/#how as they seem to only use this for more than 2 licenses. As this field is supposed to be machine-readable would be cool to have some tool to check if licenses can be read out correctly

@alexcos20
Copy link
Member Author

solidity compiler already does this, we have no more warnings

@alexcos20 alexcos20 merged commit c0a1b96 into v4main_postaudit Jan 18, 2022
@alexcos20 alexcos20 deleted the feature/proper_licence branch January 18, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper licences
2 participants