Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split orders & fees #470

Merged
merged 4 commits into from
Jan 19, 2022
Merged

split orders & fees #470

merged 4 commits into from
Jan 19, 2022

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Jan 18, 2022 •
edited

Closes #472

Changes proposed in this PR:

  • add validUntil to ProviderFees
  • add reuseOrder function
  • change parameters for startOrder and helpers

@alexcos20 alexcos20 added Status: DoNotMerge Don't merge this PR Breaking changes Breaking changes labels Jan 18, 2022
@alexcos20 alexcos20 added this to the V4 milestone Jan 18, 2022
@alexcos20 alexcos20 self-assigned this Jan 18, 2022
@alexcos20 alexcos20 marked this pull request as ready for review January 19, 2022 09:38
@alexcos20 alexcos20 linked an issue Jan 19, 2022 that may be closed by this pull request
Separate data access & provider resources #472
Closed
@alexcos20 alexcos20 removed the Status: DoNotMerge Don't merge this PR label Jan 19, 2022
@alexcos20 alexcos20 merged commit 5e0fffb into v4main_postaudit Jan 19, 2022
@alexcos20 alexcos20 deleted the feature/split_order_and_fees branch January 19, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lacoop6tu lacoop6tu Awaiting requested review from lacoop6tu

@trentmc trentmc Awaiting requested review from trentmc

Assignees

@alexcos20 alexcos20

Labels
Breaking changes Breaking changes
Projects
None yet
Milestone
V4
Development

Successfully merging this pull request may close these issues.

Separate data access & provider resources
1 participant
@alexcos20