dynamic OPC fees #480
Merged
dynamic OPC fees #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What's stopping writing tests? |
|
@lacoop6tu needs to rewrite all tests, seems that hardhat has a new issue now and everything related to forking is not working any more |
trentmc
requested changes
Jan 25, 2022
artifacts/contracts/interfaces/IFactoryRouter.sol/IFactoryRouter.json
Outdated
Show resolved
Hide resolved
Is there a github issue for this? |
|
lacoop6tu
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476
Changes proposed in this PR:
PS: need tests, but blocked right now because tests are not available