Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #563 & #564 #566

Merged
merged 3 commits into from
Mar 17, 2022
Merged

fix #563 & #564 #566

merged 3 commits into from
Mar 17, 2022

Conversation

alexcos20
Copy link
Member

Closes #563
Closes #564

Changes:

  • When deploying a new FixedRate or Dispenser, you need ERC20Deployer role
  • When an owner tries to set FixedRateExchange.toggleMintState, we check if the owner still has rights
  • When nft.transfer is called, all ERC20 will do:
    • _terminateAllMintFixedRates - loops through every FixedRate for that datatoken, and if that fixedrate has mint right, will be deleted (transfering all funds to owner (datatokens, basetokens), marketFees and OPCFees
    • _terminateAllMintDispensers- loops through every Dispenser for that datatoken, and if that dispenser has mint right, will be deleted

@alexcos20 alexcos20 added this to the V4 milestone Mar 16, 2022
@alexcos20 alexcos20 self-assigned this Mar 16, 2022
@alexcos20 alexcos20 requested a review from trentmc as a code owner March 16, 2022 07:58
This was linked to issues Mar 16, 2022
Mint attack on FixedRateExchange using NFT.transfer #563
Closed
Mint attack on FixedRateExchange using worthless ERC20 #564
Closed
@alexcos20 alexcos20 requested a review from mihaisc March 16, 2022 07:59
@alexcos20
Copy link
Member Author

Got confirmation from halborn that all 4 issues are false positive, so we are good to merge this

@alexcos20 alexcos20 merged commit ee34bfb into feature/v1.0.0-rc1 Mar 17, 2022
@alexcos20 alexcos20 deleted the bug/fre_vulnerabilities branch March 17, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc Awaiting requested review from trentmc

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
V4
Development

Successfully merging this pull request may close these issues.

Mint attack on FixedRateExchange using worthless ERC20 Mint attack on FixedRateExchange using NFT.transfer
1 participant
@alexcos20