Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-transferable NFT #598

Merged
merged 7 commits into from
Mar 31, 2022
Merged

non-transferable NFT #598

merged 7 commits into from
Mar 31, 2022

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Mar 30, 2022 •
edited

Closes #597
Closes #599

Breaking changes proposed in this PR:

  • ERC721Factory.deployERC721Contract has an two extra arguments:

    • (bool transferable - if set to false, then NFT is non-transferable)
    • (address owner) - set the owner of the nft

  • ERC721Factory.NftCreateData structure has those two extra fields ( structure is required by all ERC721Factory.createNFTWith..... functions)

@alexcos20 alexcos20 added the Breaking changes Breaking changes label Mar 30, 2022
@alexcos20 alexcos20 added this to the V4 milestone Mar 30, 2022
@alexcos20 alexcos20 self-assigned this Mar 30, 2022
@alexcos20 alexcos20 requested a review from trentmc as a code owner March 30, 2022 17:38
@alexcos20 alexcos20 merged commit 1c6008a into v4main Mar 31, 2022
@alexcos20 alexcos20 deleted the feature/non_transferable_nft branch March 31, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc Awaiting requested review from trentmc

Assignees

@alexcos20 alexcos20

Labels
Breaking changes Breaking changes
Projects
None yet
Milestone
V4
Development

Successfully merging this pull request may close these issues.

Allow NFT creator to set owner Support non-transferable data NFTs, for credential & identity use cases
1 participant
@alexcos20