Rollback ve changes

[trizin]

Changes proposed in this PR:

Rollback changes to ve contracts.

[trentmc]

Thanks. Could you show a diff of our code, and the original ve code? Perhaps right before doing the diff, replace CRV with OCEAN.

[trizin]

I've updated the veDelegation and veDelegationProxy contracts with the latest from Curve.

We made modifications in veOCEAN.vy and veFeeDistributor.vy.
Here is the veFeeDistributor diff
Here is the veOCEAN diff

[trentmc]

We made modifications in veOCEAN.vy and veFeeDistributor.vy. Here is the veFeeDistributor diff Here is the veOCEAN diff

That's the diff between our code before the PR, and our code after the PR. (Or did I miss something?)

I'm interested to see the diff between our code after the PR, and Curve's code.

[trizin]

Oh I see. In this PR, for each contract, I copy pasted the code from the Curve repo and replaced CRV with OCEAN in the code comments.

Here are the original contracts from Curve repos:
veOCEAN (Change: A small fix in code comment)
veFeeDistributor (Change: Replaced CRV with OCEAN in comments)
veDelegation (Change: Replaced CRV with OCEAN in comments)
veDelegationProxy (Change: Replaced CRV with OCEAN in comments)

The contracts should be identical, excluding the comments.

[alexcos20]

Looks like we are using different vyper versions for contracts:

-0.3.1 in https://github.com/oceanprotocol/contracts/blob/rollback-ve-changes/contracts/ve/veDelegation.vy#L1
-0.2.15 in https://github.com/oceanprotocol/contracts/blob/rollback-ve-changes/contracts/ve/veDelegationProxy.vy#L1
-0.2.7 in https://github.com/oceanprotocol/contracts/blob/rollback-ve-changes/contracts/ve/veFeeDistributor.vy#L1
-0.2.4 in https://github.com/oceanprotocol/contracts/blob/rollback-ve-changes/contracts/ve/veOCEAN.vy#L1

Although, technically, is not an issue (we can download all those compilers), I do wonder if we can stick with one version for all contracts

[alexcos20]

lgtm

[trizin]

@alexcos20 in the previous version I upgraded the contract versions. In the PR, I set them as in original contracts in case there could be a security issue. Maybe I'm being too paranoid.