Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix predictoor-pm#10: Build prototype 3 #745

Closed
wants to merge 1 commit into from
Closed

Fix predictoor-pm#10: Build prototype 3 #745

wants to merge 1 commit into from

Conversation

trentmc
Copy link
Member

@trentmc trentmc commented Apr 14, 2023 •
edited
Loading

@trentmc trentmc requested a review from alexcos20 as a code owner April 14, 2023 08:53
@trentmc trentmc marked this pull request as draft April 14, 2023 08:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 14, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@trentmc
Copy link
Member Author

trentmc commented Apr 24, 2023

Closing, because we're actually making the smart contract changes in the ocean.py prototype, no here
oceanprotocol/ocean.py#1402

(for prototype)

@trentmc trentmc closed this Apr 24, 2023
@trentmc trentmc deleted the predictoor-pm-issue-3 branch April 24, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@trentmc