Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add ve fee distributor owner #746

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Apr 24, 2023

Closes #747

To do:

  • write contract
  • write tests
  • deploy it on mainnet (will do in another PR)

@alexcos20 alexcos20 changed the base branch from main to issue743-add-vesting-wallet-and-splitter-contracts April 24, 2023 12:50
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@alexcos20 alexcos20 requested a review from trizin April 24, 2023 13:02
@alexcos20 alexcos20 self-assigned this Apr 24, 2023
Copy link
Contributor

@trizin trizin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

contracts/ve/veFeeDistributorOwner.sol Show resolved Hide resolved
@alexcos20 alexcos20 marked this pull request as ready for review April 25, 2023 12:39
@alexcos20 alexcos20 requested a review from trentmc as a code owner April 25, 2023 12:39
@alexcos20 alexcos20 merged commit 9ca4f41 into issue743-add-vesting-wallet-and-splitter-contracts Apr 27, 2023
@alexcos20 alexcos20 deleted the feature/add_veFeeDistributor_owner branch April 27, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate veFeeDistributor checkpoints
2 participants