Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predictoor updates, see comments #753

Merged
merged 4 commits into from May 14, 2023
Merged

Predictoor updates, see comments #753

merged 4 commits into from May 14, 2023

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented May 13, 2023 •
edited

Changes proposed in this PR:

  • rail every blockNum function args to slot, instead of revert
  • payout function never reverts
  • renamed to ERC20Template3
  • events are storing slot, it will be easier to group it in subgraph
  • truval_submitted it's an enum now, instead of bool
  • removed external addMinter function
  • refactor soonest_block_to_predict (there is blockNo diff between get and actual prediction block)
  • added SettingChanged event

@alexcos20 alexcos20 requested review from trentmc and trizin May 13, 2023 08:29
@alexcos20 alexcos20 self-assigned this May 13, 2023
@alexcos20 alexcos20 added the Status: InProgress Work in progress, don't merge label May 13, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2023
View reviewed changes
contracts/templates/ERC20Template3.sol Dismissed Show dismissed Hide dismissed
@alexcos20 alexcos20 marked this pull request as ready for review May 13, 2023 11:35
github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2023
View reviewed changes
contracts/templates/ERC20Template3.sol
_blocknum = slotted_blocknum + 2 * blocks_per_epoch;
}
return _blocknum;
function soonest_block_to_predict(uint256 prediction_block) public view returns (uint256) {

Check warning

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter ERC20Template3.soonest_block_to_predict(uint256).prediction_block is not in mixedCase
@trentmc trentmc merged commit ca6b648 into test/dt3 May 14, 2023
8 checks passed
@trentmc trentmc deleted the feature/update_template3 branch May 14, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc approved these changes

@trizin trizin Awaiting requested review from trizin

Assignees

@alexcos20 alexcos20

Labels
Status: InProgress Work in progress, don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexcos20 @trentmc