Use timestamp instead of block number in predictoor #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trizin
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
| } | ||
|
|
||
| function soonestBlockToPredict(uint256 prediction_block) public view returns (uint256) { | ||
| function soonestEpochToPredict(uint256 prediction_ts) public view returns (uint256) { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
…s-for-prediction Hide stake amounts for prediction epoch & Allow predictoors modify their stake amount
| } | ||
|
|
||
| function getTotalStake( | ||
| uint256 epoch_start |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
…fter_trueval expose agg predval after trueval
|
I just noticed this PR. Why isn't it merged? (And it's an important thing to do) cc @trizin |
trentmc
approved these changes
Aug 16, 2023
alexcos20
deleted the
issue779-use-timestamp-instead-of-block-number-in-predictoor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779
Changes proposed in this PR: