Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce docker size #787

Merged
merged 1 commit into from Aug 2, 2023
Merged

reduce docker size #787

merged 1 commit into from Aug 2, 2023

Conversation

alexcos20
Copy link
Member

Closes #784

@alexcos20 alexcos20 requested a review from trentmc as a code owner August 2, 2023 08:02
@alexcos20 alexcos20 self-assigned this Aug 2, 2023
@alexcos20 alexcos20 added the Status: DoNotMerge Don't merge this PR label Aug 2, 2023
trentmc
trentmc approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, but I don't have deep expertise here. I'm assuming that you've got tests passing, or that tests will come right after merge. Therefore to move this forward, approving!

@alexcos20 alexcos20 changed the base branch from main to feature/check_deployment August 2, 2023 09:33
@alexcos20 alexcos20 merged commit 36c5708 into feature/check_deployment Aug 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc approved these changes

Assignees

@alexcos20 alexcos20

Labels
Status: DoNotMerge Don't merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce docker image size
2 participants
@alexcos20 @trentmc