Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setBatchAllocation #267

Merged
merged 6 commits into from
Sep 5, 2022
Merged

add setBatchAllocation #267

merged 6 commits into from
Sep 5, 2022

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Sep 3, 2022 •
edited
Loading

Fixes # .

Changes proposed in this PR:

  • add setBatchAllocation to veAllocate.sol, which emits a new event called AllocationSetMultiple

(PS: Once approved and merged, I will copy the changes to ocean-contracts, release a new version and update subgraph)

@alexcos20 alexcos20 self-assigned this Sep 3, 2022
@alexcos20 alexcos20 mentioned this pull request Sep 3, 2022
Merged
2 tasks
trizin
trizin approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@trizin trizin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alexcos20 alexcos20 merged commit e129ecb into main Sep 5, 2022
@alexcos20 alexcos20 deleted the feature/ve_batch_allocate branch September 5, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trizin trizin trizin approved these changes

@trentmc trentmc Awaiting requested review from trentmc

@idiom-bytes idiom-bytes Awaiting requested review from idiom-bytes

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexcos20 @trizin