SEO component #63
Merged
SEO component #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Twitter Cards * OpenGraph * schema.org
kremalicious
force-pushed
the
feature/seo
branch
from
e1d55ce
to
bbb67d7
Compare
kremalicious
force-pushed
the
feature/seo
branch
from
74a9edc
to
aabe287
Compare
|
Using the developer tools in Firefox on the homepage (rendered locally), I see:
which looks good to me. I saw much the same on https://betadocs.oceanprotocol.com All good so far! When I Tweeted the URL https://betadocs.oceanprotocol.com I saw this:
which is based on the Twitter meta tags. For some reason, there's no image. I looked at the meta tag for the Twitter image: <meta name="twitter:image" content="https://docs.oceanprotocol.com/static/share-6ccc8d624898a3705cd0379e082620b4.png" data-react-helmet="true">but there's nothing at that URL. I get the 404 page. |
|
Yes, the image url is prepended with live host url so image won’t work right now on beta. Image is there though |
ttmc
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate all the
<Helmet />calls into one SEO component for dynamictitle&metatags in<head>.Handling: