Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add lastPriceToken #567

Merged
merged 3 commits into from Nov 21, 2022
Merged

add lastPriceToken #567

merged 3 commits into from Nov 21, 2022

Conversation

mihaisc
Copy link
Contributor

@mihaisc mihaisc commented Oct 25, 2022

Closes #447

@mihaisc mihaisc requested review from alexcos20 and jamiehewitt15 and removed request for alexcos20 October 25, 2022 14:15
@mihaisc mihaisc marked this pull request as draft October 25, 2022 14:40
@jamiehewitt15
Copy link
Member

Seems good, just the tests that need fixing I think

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review November 17, 2022 14:21
@mihaisc
Copy link
Contributor Author

mihaisc commented Nov 18, 2022

👍 can't give a review since i created it , so you have to approve it

@alexcos20
Copy link
Member

good to go, but please do not have a release now
we will merge more breaking changes in one release

@mihaisc mihaisc merged commit 6c4fc1c into main Nov 21, 2022
@mihaisc mihaisc deleted the fix/447 branch November 21, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change type of lastPriceToken from string to Token
3 participants
@mihaisc @jamiehewitt15 @alexcos20