Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/basic ve ocean #1595

Merged
merged 20 commits into from Sep 6, 2022
Merged

Feature/basic ve ocean #1595

merged 20 commits into from Sep 6, 2022

Conversation

alexcos20
Copy link
Member

@alexcos20 alexcos20 commented Sep 5, 2022 •
edited

Add basic veOcean support:

  • lock, deposit_for, increase_lock, increase_amount, withdraw (veOcean)
  • claim (veFees)
  • setAllocate & setBatchAllocate (veAllocation)

Bump ocean-contracts to 1.1.3

@alexcos20 alexcos20 self-assigned this Sep 5, 2022
@alexcos20 alexcos20 marked this pull request as ready for review September 6, 2022 08:03
@alexcos20
Copy link
Member Author

Integration test are failing, but they are not touched in this PR

2022-09-05 19:03:01 ad081f7e6841 ocean_provider.routes.compute[68] ERROR Invalid container values provided on algorithm. Check image, tag and checksum.

@bogdanfazakas
Copy link
Member

Integration test are failing, but they are not touched in this PR

2022-09-05 19:03:01 ad081f7e6841 ocean_provider.routes.compute[68] ERROR Invalid container values provided on algorithm. Check image, tag and checksum.

Yep, most likely the checksum we set for the ubuntu container is no longer available on docker hub. Will quickly check

@mihaisc mihaisc self-requested a review September 6, 2022 11:59
@alexcos20 alexcos20 merged commit f8f4b48 into v4refactoring Sep 6, 2022
@alexcos20 alexcos20 deleted the feature/basic_veOcean branch September 6, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc mihaisc approved these changes

@kremalicious kremalicious Awaiting requested review from kremalicious

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas

Assignees

@alexcos20 alexcos20

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexcos20 @bogdanfazakas @mihaisc