Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable fileinfo provider tests #858

Closed
wants to merge 1 commit into from
Closed

disable fileinfo provider tests #858

wants to merge 1 commit into from

Conversation

kremalicious
Copy link
Contributor

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2021

Code Climate has analyzed commit 8f46b44 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 79.7% (-0.2% change).

View more on Code Climate.

@kremalicious
Copy link
Contributor Author

we might not need this if oceanprotocol/provider#160 is successful in a new provider release

@mihaisc
Copy link
Contributor

mihaisc commented Jun 23, 2021

It's close to done, so if there is no hurry we can wait a bit.

@kremalicious
Copy link
Contributor Author

closing, as provider v0.4.12 coming with oceanprotocol/barge#253 should not have those issues anymore

@kremalicious kremalicious deleted the fix/fileinfo-tests branch June 25, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc mihaisc approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kremalicious @mihaisc