Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sub-EPIC] Add unit tests & refactor submodules #13

Closed
8 tasks done
trizin opened this issue Aug 2, 2023 · 1 comment
Closed
8 tasks done

[Sub-EPIC] Add unit tests & refactor submodules #13

trizin opened this issue Aug 2, 2023 · 1 comment
Labels
Epic

Comments

@trizin
Copy link
Contributor

trizin commented Aug 2, 2023 •
edited by trentmc
Loading

[Part of epic #50 "Ship MVP"]

TODOs

Add unit tests & refactor submodules for each of:

  • utils
    • [Trent] subgraph 5b364d2
    • [T] constants 5b364d2
    • [Berkay] contract.py - Berkay PR
    • [B,Calina] Berkay walk Calina through unit-testing setup, general onboard into pdr-backend
  • [C,T] predictoor
  • [C] trader
  • [B] trueval
  • dfbuyer --> moved to #128
  • publisher --> moved to #129
@trizin trizin mentioned this issue Aug 3, 2023
Merged
trentmc added a commit that referenced this issue Aug 3, 2023
@trentmc
Towards #13: add unit tests
ab49789
@trentmc trentmc mentioned this issue Aug 3, 2023
Merged
trentmc added a commit that referenced this issue Aug 4, 2023
@trentmc
Towards #13: utils.subgraph refactor & tests. Via merge PR #17
5b364d2 
Towards #13: 
- refactor utils.subgraph
- thorough tests for utils.subgraph
- tests for utils.constants (simple)
- rename test modules so that no overlap in names (causes pycache problems)
@trentmc trentmc mentioned this issue Aug 4, 2023
Merged
trentmc added a commit that referenced this issue Aug 4, 2023
@trentmc
Towards #13: add some tests for utils.contracts. Merge PR #24
7c4f2ac 
(Still many more tests to go for utils.contracts)
This was referenced Aug 11, 2023
Merged
Closed
@trentmc trentmc added the Epic label Aug 18, 2023
@trentmc trentmc changed the title Add unit tests [Sub-epic] Add unit tests Aug 18, 2023
@trentmc trentmc mentioned this issue Aug 18, 2023
Closed
@trentmc trentmc changed the title [Sub-epic] Add unit tests [Sub-EPIC] Add unit tests Aug 18, 2023
@trentmc trentmc mentioned this issue Aug 26, 2023
Merged
trentmc pushed a commit that referenced this issue Aug 26, 2023
@calina-c @trizin
Towards #13: add predictoor tests (#88)
70bacb1 
Co-authored-by: trizin <25263018+trizin@users.noreply.github.com>
trentmc added a commit that referenced this issue Aug 28, 2023
@trentmc
Towards #13: tests & refactoring predictoor/
0737408
@trentmc trentmc mentioned this issue Aug 28, 2023
Merged
@trentmc trentmc changed the title [Sub-EPIC] Add unit tests [Sub-EPIC] Add unit tests & refactor submodules Aug 29, 2023
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: rename ContractData -> Feed
8c6f159
@trentmc trentmc mentioned this issue Aug 31, 2023
Merged
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: rename ContractData -> Feed (#108)
724d14d 
Towards #13
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: Slot.slot -> Slot.slot_number
07f056f
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: refactor: create BaseConfig, and make TruevalConfig inhe…
593b3e0 
…rit from it
@trentmc trentmc mentioned this issue Aug 31, 2023
Merged
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: refactor: create BaseConfig, and make TruevalConfig inhe…
0638100 
…rit from it (#109)
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: query_predictContracts -> query_feed_contracts; get_feed…
8fd8b38 
…s() returns a dict of addr:Feed not addr:dict
@trentmc trentmc mentioned this issue Aug 31, 2023
Merged
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: rename query_predictContracts -> query_feed_contracts
8055e5e
@trentmc trentmc mentioned this issue Aug 31, 2023
Merged
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: rename query_predictContracts -> query_feed_contracts (#114
3ddd142 
)
trentmc added a commit that referenced this issue Aug 31, 2023
@trentmc
Towards #13: make get_feeds() returns dict of Feed, not dict of dict (#…
97f74a1 
…111)

Towards #13
trentmc added a commit that referenced this issue Sep 1, 2023
@trentmc
Towards #13: tests & refactoring predictoor/agent1 (#101)
d788942 
Towards #13
- refactoor & test predictoor/agent1 
  - agent- and object-oriented via PredictoorAgent1
  - config is OO too. PredictoorConfig1 uses model/base_config.py::BaseConfig
  - thorough tests for predictoor/agent1 via generous mocking
- added util/strutil.py incl StrMixin. Used it BaseConfig, Feed, more.
  - Feed has both shortstr() and longstr() now 
- use "1" and "2" more liberally in approach1 and 2 filenames. Helps minimize confusion
@trentmc
Copy link
Member

trentmc commented Sep 4, 2023

This is all done except publisher and dfbuyer agents. They're less urgent. Therefore I've created a new github to test & refactor each of those; and we can schedule accordingly.

Therefore this github issue is done!

@trentmc trentmc closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trentmc @trizin