Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dfbuyer should handle gas related reverts #171

Closed
1 task
trizin opened this issue Sep 22, 2023 · 0 comments · Fixed by #172
Closed
1 task

dfbuyer should handle gas related reverts #171

trizin opened this issue Sep 22, 2023 · 0 comments · Fixed by #172
Assignees
@trizin
Labels
Type: Bug Something isn't working

Comments

@trizin
Copy link
Contributor

trizin commented Sep 22, 2023

Background

sometimes dfbuyer fails due to gas limit

DoD

  • dfbuyer should handle gas related reverts by decreasing the number of contracts processed or the number of consumes and retrying consume
@trizin trizin added the Type: Bug Something isn't working label Sep 22, 2023
@trizin trizin self-assigned this Sep 22, 2023
@trizin trizin linked a pull request Sep 22, 2023 that will close this issue
#171 - dfbuyer should handle gas related reverts #172
Merged
@trizin trizin mentioned this issue Sep 23, 2023
Merged
trizin added a commit that referenced this issue Sep 23, 2023
@trizin
#171 - dfbuyer should handle gas related reverts (#172)
3427808 
* Increase default gas limit

* Retry in smaller chunks on revert

* Add tests for new functions

* Fix linter issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trizin trizin

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#171 - dfbuyer should handle gas related reverts oceanprotocol/pdr-backend
1 participant
@trizin